[PATCH] D143557: [CMake][compiler-rt] Support clang-cl in CompilerRTMockLLVMCMakeConfig

[Brittany Blue Gaston via Phabricator via llvm-commits]

thetruestblue added a comment.

This seems reasonable and fine to me.
Though I'd feel better if someone familiar with MSVC/Windows gave approval.



================
Comment at: compiler-rt/cmake/Modules/CompilerRTMockLLVMCMakeConfig.cmake:52
+        # This means we are using clang-cl and it requires
+        # /clang: as prefix for dumpmachine argument.
+        set(DUMPMACHINE_ARG /clang:-dumpmachine)
----------------
NIT: Single line comment suggestion: 

```
# Use /clang:-dumpmachine for clang-cl.
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143557/new/

https://reviews.llvm.org/D143557