[PATCH] D143508: [ELF][llvm-objcopy] Reject duplicate SHT_SYMTAB sections.

Moshe via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 8 08:13:33 PST 2023


MosheBerman added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/ELF/symtab-duplicate.test:10
+  Type:    ET_DYN
+  Machine: EM_X86_64
+Sections:
----------------
jhenderson wrote:
> I believe the `Machine` line is unnecessary these days, as a default value is provided that should be sufficient (I could be getting mixed up with something else though, so if an error starts to be generated after removing it, put it back in!).
Tests pass locally without it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143508/new/

https://reviews.llvm.org/D143508



More information about the llvm-commits mailing list