[PATCH] D142194: [AMDGPU][AsmParser] Fix matching immediate literals.

Dmitry Preobrazhensky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 8 08:06:38 PST 2023


dp accepted this revision.
dp added a comment.
This revision is now accepted and ready to land.

LGTM, but I suggest moving the test to some other place. `*_unsupported.s` are used solely to test identification of unsupported opcodes. `gfx7_err_pos.s` may be a better place for this test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142194/new/

https://reviews.llvm.org/D142194



More information about the llvm-commits mailing list