[PATCH] D143508: [ELF][llvm-objcopy] Reject duplicate SHT_SYMTAB sections.

Wed Feb 8 08:00:25 PST 2023

MosheBerman added inline comments.

================
Comment at: llvm/test/tools/llvm-objcopy/ELF/symtab-duplicate.test:14
+    Type: SHT_SYMTAB
+    Flags: [ SHF_ALLOC ]
+  - Name: .symtab2
----------------
jhenderson wrote:
> Symbol tables generally don't have the SHF_ALLOC flag, so you can delete this and the equivalent line below.
Do I delete the contents of the brackets or the entire line?

(Sidebar, what's the idiomatic term for the brackets here? Is it 'Array,' 'List,' 'Set,' or something else?

================
Comment at: llvm/test/tools/llvm-objcopy/ELF/symtab-duplicate.test:18-19
+    Flags: [ SHF_ALLOC ]
+    
\ No newline at end of file

----------------
jhenderson wrote:
> Looks like there's trailing whitespace on the final line, hence the "No newline at end of file" message, even though there is a blank line here.
Ooh, thanks for explaining this. (My VS Code is auto-formatting incorrectly) I'll run clean it up.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143508/new/

https://reviews.llvm.org/D143508