[PATCH] D143573: AMDGPU/MC: Add assembler tests for v2f32 and v2b32 with imm operand

[Dmitry Preobrazhensky via Phabricator via llvm-commits]

dp added inline comments.


================
Comment at: llvm/test/MC/Disassembler/AMDGPU/gfx90a_features.txt:54
 
+# GFX90A: v_pk_fma_f32 v[0:1], v[2:3], v[4:5], 0  ; encoding: [0x00,0x40,0xb0,0xd3,0x02,0x09,0x02,0x1a]
+0x00,0x40,0xb0,0xd3,0x02,0x09,0xca,0x1b
----------------
It is unusual to add invalid tests with the purpose of fixing them in a separate patch.
At a minimum, I think you should mention this in the description and make these patches dependent (stacked). Or they could be merged.
Aside from that, both patches look good, thanks.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143573/new/

https://reviews.llvm.org/D143573