[PATCH] D142375: [AMDGPU][CodeGen] Combine SDAG and global isel tests for intersect ray intrinsics.

Wed Feb 8 04:18:13 PST 2023

arsenm added a comment.

In D142375#4112661 <https://reviews.llvm.org/D142375#4112661>, @foad wrote:

> In D142375#4110027 <https://reviews.llvm.org/D142375#4110027>, @kosarev wrote:
>
>> The only differences between the tests discovered are the use of `inreg`
>
> Generally we would not bother with `inreg` except for instruction operands that have to go in SGPRs. But it doesn't really matter. At worst, it will bloat the output with some extra SGPR-to-VGPR copies.
>
>> and flattened arguments instead of vector ones in SDAG tests. I assumed that's what we prefer for the combined tests.
>
> Again it doesn't really matter. Personally I would use vector arguments because it keeps the IR nice and short.

No no, all the permutations should be tested. This is not a cosmetic choice, we should be testing these are handled correctly

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142375/new/

https://reviews.llvm.org/D142375