[PATCH] D143561: [DebugInfo] Check if dwarf address section exists
Benjamin Maxwell via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 8 03:40:01 PST 2023
benmxwl-arm added inline comments.
================
Comment at: llvm/unittests/DebugInfo/DWARF/DwarfGenerator.cpp:586-587
+ // Some targets might not have dwarf address section.
+ if (MCSection *AddrSection = TLOF->getDwarfAddrSection())
+ AddressPool.emit(*Asm, AddrSection, AddrTableStartSym);
----------------
Maybe change this to `if (Version >= 5)`, it looks like the DWARF5 tests are already disabled for AIX, so that should achieve the same effect (if that were not the case these tests would still fail on AIX with this change).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143561/new/
https://reviews.llvm.org/D143561
More information about the llvm-commits
mailing list