[PATCH] D143536: [llvm-lib 1/5] Write object files in reversed order.

Hans Wennborg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 8 03:29:10 PST 2023


hans added inline comments.


================
Comment at: llvm/lib/ToolDrivers/llvm-lib/LibDriver.cpp:143
+  for (auto Name = Names.rbegin(); Name != Names.rend(); ++Name)
+    llvm::outs() << *Name << '\n';
   fatalOpenError(std::move(Err), B->getBufferIdentifier());
----------------
Do we have a test covering the order of these printed filenames?

It's surprising to me that we need to reverse here, but if it matches msvc it sounds good to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143536/new/

https://reviews.llvm.org/D143536



More information about the llvm-commits mailing list