[PATCH] D127115: [RFC][DAGCombine] Make sure combined nodes are added back to the worklist in topological order.

Paweł Bylica via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 8 00:19:28 PST 2023


chfast added inline comments.


================
Comment at: llvm/test/CodeGen/X86/avx512vl-vec-masked-cmp.ll:2663
+; VLX-NEXT:    kmovd %k0, %eax
+; VLX-NEXT:    andl $3, %eax
 ; VLX-NEXT:    retq
----------------
RKSimon wrote:
> deadalnix wrote:
> > chfast wrote:
> > > Is this a regression?
> > Yes, I think so. On the other hand, the no vlx case got improved :)
> Looking at this - it looks like combineScalarAndWithMaskSetcc needs to be tweaked to peek through any_extend() nodes
Looks like fixed now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127115/new/

https://reviews.llvm.org/D127115



More information about the llvm-commits mailing list