[PATCH] D143535: github: Add manual workflow to build and upload release binaries

[Tobias Hieta via Phabricator via llvm-commits]

thieta added a comment.

Thanks for working on this! I have a bunch of comments :)



================
Comment at: .github/workflows/release-binaries.yml:9
+        required: true
+        default: 'true'
+
----------------
tstellar wrote:
> Should we add an option to specify the ref/tag ?
+1


================
Comment at: .github/workflows/release-binaries.yml:34-43
+        test "${{ github.actor }}" = "tstellar" || test "${{ github.actor }}" = "tru"
+        echo "${{ github.ref_name }}" | grep -e '^llvmorg-[0-9]\+\.[0-9]\+\.[0-9]\+\(-rc[0-9]\+\)\?$'
+        release_version=`echo "${{ github.ref_name }}" | sed 's/llvmorg-//g'`
+        release=`echo "$release_version" | sed 's/-.*//g'`
+        build_dir=`echo "$release_version" | sed 's,^[^-]\+,final,' | sed 's,[^-]\+-rc\(.\+\),rc\1,'`
+        rc_flags=`echo "$release_version" | sed 's,^[^-]\+,-final,' | sed 's,[^-]\+-rc\(.\+\),-rc \1 -test-asserts,' | sed 's,--,-,'`
+        echo "release-version=$release_version" >> $GITHUB_OUTPUT
----------------
This block is very messy. I would l prefer if this ended up in a script or something instead. Going to be complicated to troubleshoot this logic when it lives in the action definition.


================
Comment at: .github/workflows/release-binaries.yml:53
+        target:
+          - triple: x86_64-linux-gnu-ubuntu-22.04
+            runs-on: ubuntu-22.04-8x32
----------------
Is this the correct triple? I would have expected `x86_64-unknown-linux-gnu` or something similar instead. At least since we pass this directly as LLVM_DEFAULT_TARGET I think we need to be careful to get this right.

Probably better to have a `buildname` and `triple` separated.


================
Comment at: .github/workflows/release-binaries.yml:87
+        -no-checkout
+        -no-test-suite || true
+
----------------
if we pipe this to true won't we miss errors that happens here then?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143535/new/

https://reviews.llvm.org/D143535