[PATCH] D143551: [VP][DAGCombiner] Remove unused-private-field VPMatchContext.Root

Jie Fu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 7 22:24:17 PST 2023


DamonFool created this revision.
DamonFool added reviewers: fakepaper56, craig.topper, RKSimon, frasercrmck, mehdi_amini, MaskRay.
DamonFool added a project: LLVM.
Herald added subscribers: ecnelises, steven.zhang, hiraditya.
Herald added a project: All.
DamonFool requested review of this revision.
Herald added a subscriber: llvm-commits.

LLVM fails to build after D141891 <https://reviews.llvm.org/D141891> due to -Wunused-private-field of VPMatchContext.Root
llvm-project/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:870:11: error: private field 'Root' is not used [-Werror,-Wunused-private-field]

  SDNode *Root;
          ^

1 error generated.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D143551

Files:
  llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp


Index: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
===================================================================
--- llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
+++ llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
@@ -867,13 +867,12 @@
 
 class VPMatchContext {
   SelectionDAG &DAG;
-  SDNode *Root;
   SDValue RootMaskOp;
   SDValue RootVectorLenOp;
 
 public:
   VPMatchContext(SelectionDAG &DAG, SDNode *Root)
-      : DAG(DAG), Root(Root), RootMaskOp(), RootVectorLenOp() {
+      : DAG(DAG), RootMaskOp(), RootVectorLenOp() {
     assert(Root->isVPOpcode());
     if (auto RootMaskPos = ISD::getVPMaskIdx(Root->getOpcode()))
       RootMaskOp = Root->getOperand(*RootMaskPos);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D143551.495727.patch
Type: text/x-patch
Size: 690 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230208/78d1dff8/attachment.bin>


More information about the llvm-commits mailing list