[PATCH] D142711: AArch64: count call stack when working out if scavenging is needed

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 7 20:45:27 PST 2023


efriedma added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:3084
+    if (FixedOff > CalleeStackUsed) CalleeStackUsed = FixedOff;
+  }
+
----------------
To be clear, this is looking at arguments passed on the stack by the caller of this function definition?  If we use a frame index to access them, and we don't have a frame pointer, they need to count towards the stack limit, sure.

Referring to this as the "callee's stack" is a bit confusing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142711/new/

https://reviews.llvm.org/D142711



More information about the llvm-commits mailing list