[PATCH] D143541: [llvm-lib 5/5] Add support for ARM64EC libraries.

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

I'll try to find time to review in more detail soon... unless someone else wants to review.  (I'm not really that familiar with this code, but I doubt anyone has looked at it in years anyway.)  Leaving a couple quick comments from my first glance.

If you're going to number your patches, please use some sort of consistent numbering... but you don't need to number a "series" like this.  Just stacking them in Phabricator is enough.  Maybe change the refactoring patches to explicitly put [NFC] in the title.



================
Comment at: llvm/lib/Object/ArchiveWriter.cpp:574
+    return T.getArch() == Triple::aarch64 &&
+           T.getSubArch() == Triple::AArch64SubArch_arm64ec;
+  }
----------------
`T.isWindowsArm64EC()`


================
Comment at: llvm/lib/ToolDrivers/llvm-lib/LibDriver.cpp:262
     if (FileMachine != COFF::IMAGE_FILE_MACHINE_UNKNOWN) {
       if (LibMachine == COFF::IMAGE_FILE_MACHINE_UNKNOWN) {
         LibMachine = FileMachine;
----------------
Do we need to mess with this inference code to make mixed archives work correctly?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143541/new/

https://reviews.llvm.org/D143541