[PATCH] D143226: [MC][CodeGen] Define R_RISCV_PLT32 and lower dso_local_equivalent to it

[Leonard Chan via Phabricator via llvm-commits]

leonardchan added a comment.
Herald added a subscriber: jobnoorman.

In D143226#4109617 <https://reviews.llvm.org/D143226#4109617>, @asb wrote:

> I wanted to raise something that came to mind looking at this patch, but is probably also relevant for the other recent Fuchsia related patches: typically (certainly for the llvm/test/CodeGen/RISCV and llvm/test/MC/RISCV) we try to add RV32 CHECK lines alongside RV64 lines wherever relevant. This is typically cheap to do, and of course provides just a little extra coverage, even in cases where the test isn't particularly targeted at an RV32 use case.
>
> So the two thoughts are:
>
> - Adding rv32 lines to tests like in this patch
> - Whether the same should be done for other fuchsia related patches, and relatedly if -mtriple=riscv32-fuchsia is something that isn't likely to exist and we don't want to bother testing for it, would it be better to just disallow the triple?

I'm fine with adding RV32 cases in this patch and other patches related to this if it's trivial. For fuchsia-related changes though, I think the 32-bit tests might not be necessary since Fuchsia is exclusively 64-bit so we could disallow that in a separate patch maybe.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143226/new/

https://reviews.llvm.org/D143226