[PATCH] D124330: Revert "HHVM calling conventions."

[Matthias Braun via Phabricator via llvm-commits]

MatzeB added a comment.

Makes sense to me to drop this and I like the simplification.

There is a chance that an out-of-tree target is overriding the getStackAlignmentSkew callback, but given that is at least pretty unlikely it's probably good to try to remove first and possibly bringing it back if there really was a user...

Added one nitpick but otherwise seems good to go.



================
Comment at: llvm/include/llvm/IR/CallingConv.h:162-164
+    /// Placeholders for HHVM calling conventions (deprecated, removed).
     HHVM = 81,
     HHVM_C = 82,
----------------
Maybe rename to make it more explicit this is gone now?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124330/new/

https://reviews.llvm.org/D124330