[PATCH] D143508: [ELF][llvm-objcopy] Reject duplicate SHT_SYMTAB sections.
Moshe via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 7 15:16:01 PST 2023
MosheBerman updated this revision to Diff 495653.
MosheBerman added a comment.
Changed punctuation in test so it matches the code.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143508/new/
https://reviews.llvm.org/D143508
Files:
llvm/lib/ObjCopy/ELF/ELFObject.cpp
llvm/test/tools/llvm-objcopy/ELF/symtab-duplicate.test
Index: llvm/test/tools/llvm-objcopy/ELF/symtab-duplicate.test
===================================================================
--- /dev/null
+++ llvm/test/tools/llvm-objcopy/ELF/symtab-duplicate.test
@@ -0,0 +1,18 @@
+# RUN: yaml2obj %s -o %t
+# RUN: not llvm-objcopy -O binary %t - 2>&1 | FileCheck %s --check-prefix=SYMTAB
+# SYMTAB: found multiple SHT_SYMTAB sections. Currently, an object file may have only one
+
+--- !ELF
+FileHeader:
+ Class: ELFCLASS64
+ Data: ELFDATA2LSB
+ Type: ET_DYN
+ Machine: EM_X86_64
+Sections:
+ - Name: .symtab
+ Type: SHT_SYMTAB
+ Flags: [ SHF_ALLOC ]
+ - Name: .symtab2
+ Type: SHT_SYMTAB
+ Flags: [ SHF_ALLOC ]
+
\ No newline at end of file
Index: llvm/lib/ObjCopy/ELF/ELFObject.cpp
===================================================================
--- llvm/lib/ObjCopy/ELF/ELFObject.cpp
+++ llvm/lib/ObjCopy/ELF/ELFObject.cpp
@@ -1704,6 +1704,11 @@
else
return Data.takeError();
case SHT_SYMTAB: {
+ // Duplicate SHT_SYMTAB sections are forbidden by the ELF gABI.
+ if (Obj.SymbolTable != nullptr)
+ return createStringError(llvm::errc::invalid_argument,
+ "found multiple SHT_SYMTAB sections. "
+ "Currently, an object file may have only one");
auto &SymTab = Obj.addSection<SymbolTableSection>();
Obj.SymbolTable = &SymTab;
return SymTab;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D143508.495653.patch
Type: text/x-patch
Size: 1416 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230207/9f105a79/attachment.bin>
More information about the llvm-commits
mailing list