[PATCH] D143528: [M68k] Factoring out memory operand printer into a separate file

Min-Yih Hsu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 7 14:45:37 PST 2023


myhsu created this revision.
myhsu added reviewers: 0x59616e, RKSimon, ricky26.
Herald added a subscriber: hiraditya.
Herald added a project: All.
myhsu requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

In order to support inline asm with memory constraints, AsmPrinter::PrintAsmMemOperand needs to be implemented, which has lots of overlaps with MCInstPrinter especially on the format of complex addressing modes. This patch factors out the common printing logics from MCInstPrinter into a separate class inherited by both AsmPrinter and MCInstPrinter, in which the derived classes only need to provide primitives like printOperand and printDisp.

This change is basically NFC.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D143528

Files:
  llvm/lib/Target/M68k/MCTargetDesc/M68kInstPrinter.cpp
  llvm/lib/Target/M68k/MCTargetDesc/M68kInstPrinter.h
  llvm/lib/Target/M68k/MCTargetDesc/M68kMemOperandPrinter.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D143528.495646.patch
Type: text/x-patch
Size: 6801 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230207/1ccf45c2/attachment.bin>


More information about the llvm-commits mailing list