[PATCH] D143295: [bazel] Move bazel configuration to a Python script

Tue Feb 7 13:53:27 PST 2023

thopre added a comment.

In D143295#4110430 <https://reviews.llvm.org/D143295#4110430>, @aaronmondal wrote:

> I'll have to agree with @chapuni though, Bazel has exceptional support for bash scripts etc, anything that could be expressed in starlark with genrules and bash scripts seems much better to me than python. E.g. overlaying/moving files is like 10x faster in bash than it is in python.
>
> Also, removing the python dependency would potentially make the build much more portable. I don't think this commit would be the right place to do this and I understand that pytorch/tensorflow devs may prefer using python in general.
>
> However, I think the current functionality of the script is not something where python is actually needed. I'm not sure where else we'd need python for the LLVM build, but I'd say that requiring a rather large python dependency in every CI image is not very economical when we already have starlark and bash.

Does the bazel CI run any test? If so you would already need Python for lit anyway. Also the overlay script is already in Python so continuing in Python makes sense to me. And the code I've moved to Python is very much not compute heavy so I don't think speed is really a concern.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143295/new/

https://reviews.llvm.org/D143295