[PATCH] D142647: [ConstraintElimination] Move Value2Index map to ConstraintSystem (NFC)

[Florian Hahn via Phabricator via llvm-commits]

fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM with the inline comments addressed.



================
Comment at: llvm/include/llvm/Analysis/ConstraintSystem.h:20
 namespace llvm {
-
+class Value;
 class ConstraintSystem {
----------------
nit: newline before and after/


================
Comment at: llvm/include/llvm/Analysis/ConstraintSystem.h:27
 
+  /// a Map between variabled collected in ConstraintElimination and their
+  /// corresponding index in the constraint system solver.
----------------
`A map of variables (IR values) to their corresponding index in the constraint system.` Better not mention any specific pass here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142647/new/

https://reviews.llvm.org/D142647