[PATCH] D143511: [CodeGen] Add standard print/debug utilities to MVT

[Craig Topper via Phabricator via llvm-commits]

craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/CodeGen/ValueTypes.cpp:620
+#if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP)
+void MVT::dump() const {
+  print(dbgs());
----------------
reames wrote:
> craig.topper wrote:
> > Is this a library layering issue?
> Yes, but not a new one.  MVT::getVT is defined a couple lines above, so if that links, so should this.  
I suppose it means that dump wouldn't work from gdb for tblgen, but would for other tools?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143511/new/

https://reviews.llvm.org/D143511