[PATCH] D143515: [AsmPrinter] Add hook to override constant folding for printing.

[Krzysztof Drewniak via Phabricator via llvm-commits]

krzysz00 added a comment.

Re this being a hack, agreed. I'm open to doing something more principled like you suggested.

On the missing tests front, the problem is that to add a test, I'd need to swap the GCN data layout to include a `p7:128:128:128:32` term, which, without a change like this one, causes the existing tests to crash.

Would it be more appropriate to make the data layout change first and then `XFAIL` (or comment out the relevant parts of) `nulls.ll`, to land that first, to land this despite a general lack of tests, or to put this and the data layout changes in one larger commit?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143515/new/

https://reviews.llvm.org/D143515