[PATCH] D143311: [MLGO] Add BB Profile Dump Pass for Regalloc Case

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin added inline comments.
Herald added a subscriber: jobnoorman.


================
Comment at: llvm/lib/CodeGen/MBBProfileDump.cpp:25
+             "matching up BBs with afterwards, the compilation must be "
+             "performed with -fbasic-block-sections=labels. Enabling this "
+             "flag with in-process ThinLTO in the same compiler invocation."));
----------------
The sentence ends mid air, how about "Enabling this flag during in-process ThinLTO is not supported."


================
Comment at: llvm/test/CodeGen/AMDGPU/llc-pipeline.ll:719
+; GCN-O1-OPTS-NEXT:        Lazy Machine Block Frequency Analysis
+; GCN-O1-OPTS-NEXT:        MBB Profile Dump
 ; GCN-O1-OPTS-NEXT:    Function register usage analysis
----------------
Here and below for AMDGPU, it seems like the MBB Profile Dump should run in the next FunctionPass Manager.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143311/new/

https://reviews.llvm.org/D143311