[PATCH] D142100: [DAGCombine] Allow scalable type dead store elimination

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 7 07:08:26 PST 2023


sdesmalen accepted this revision.
sdesmalen added a comment.
This revision is now accepted and ready to land.

LGTM!



================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:19824-19826
+        if (ST->getMemoryVT().isScalableVector() ||
+            ST1->getMemoryVT().isScalableVector()) {
+          if (ST1->getBasePtr() == Ptr &&
----------------
sdesmalen wrote:
> Can you combine the two if-statements with an `&&`? That saves a level of indentation.
Sorry, I misread the indentation/curly braces here. The original version was fine, thanks for restoring it!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142100/new/

https://reviews.llvm.org/D142100



More information about the llvm-commits mailing list