[PATCH] D143295: [bazel] Move bazel configuration to a Python script

NAKAMURA Takumi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 7 05:28:18 PST 2023


chapuni added a comment.

Excuse me, I am not a fan of it.
Could you remain vars.bzl stuff, unless python would have interest to vars?

I am planning for vars.bzl to give configurations to build rules (and repository rules).

FYI, re. `_extract_cmake_settings`;

- It would disappear when the central config database (among build systems) would be introduced.
- It could be rewritten smarter with python. I wrote it under restriction of starlark.

Thank you.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143295/new/

https://reviews.llvm.org/D143295



More information about the llvm-commits mailing list