[PATCH] D143409: [SCEV][IndVarSimplify] Support known dominating slt/ult elimination

[Aleksandr Popov via Phabricator via llvm-commits]

aleksandr.popov added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/SimplifyIndVar.cpp:936
     if (BinaryOperator *BO = dyn_cast<BinaryOperator>(UseInst)) {
-      if ((isa<OverflowingBinaryOperator>(BO) &&
-           strengthenOverflowingOperation(BO, IVOperand)) ||
-          (isa<ShlOperator>(BO) && strengthenRightShift(BO, IVOperand))) {
+      if (strengthenBinaryOp(BO, IVOperand)) {
         // re-queue uses of the now modified binary operator and fall
----------------
mkazantsev wrote:
> Factoring out this check into `strengthenBinaryOp` can be split off as a NFC patch. Then, make a functional patch that introduces its new use.
Thanks, will do that


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143409/new/

https://reviews.llvm.org/D143409