[PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

[Balázs Kéri via Phabricator via llvm-commits]

balazske added inline comments.


================
Comment at: clang/lib/AST/ASTImporter.cpp:3896
+  if (D->hasAttrs())
+    ToField->setAttrs(D->getAttrs());
   ToField->setAccess(D->getAccess());
----------------
The import of attributes is handled in function `ASTImporter::Import(Decl*)`. This new line will probably copy all attributes, that may not work in all cases dependent on the attribute types. This may interfere with the later import of attributes, probably these will be duplicated. What was the need for this line? (Simple attributes that do not have references to other nodes could be copied at this place.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143347/new/

https://reviews.llvm.org/D143347