[PATCH] D140404: Patch for dbg variable instrinsics to point towards cloned values in JumpThreading

[Stephen Tozer via Phabricator via llvm-commits]

StephenTozer added a comment.

Acutally looking back over it I'd add further - `FindValueForBlock` isn't necessarily right because we're looking for values in the middle of the block, and that function will give us the end. I encountered this problem in `MachineSSAUpdater`, and the approach I took there was to add a `ExistingValueOnly` parameter to `GetValue(InMiddle|AtEnd)OfBlock` that performs all the same logic but returns empty if it would need to generate any code to provide a value. Happy to repeat that fix here!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140404/new/

https://reviews.llvm.org/D140404