[PATCH] D140404: Patch for dbg variable instrinsics to point towards cloned values in JumpThreading

[Stephen Tozer via Phabricator via llvm-commits]

StephenTozer added a comment.

In D140404#4109678 <https://reviews.llvm.org/D140404#4109678>, @jmorse wrote:

> /me squints -- I think the idea here was that if SSAUpdater has a value at the end of the block we can use that and it won't cause new codegen; but then we're using `GetValueInMiddleOfBlock`, which will generate code in certain circumstances.

Ah, my bad - I've bumped into this before and saw the potential for CodeGen changes, but misread/misremembered the logic and thought that the `HasValueForBlock` check was guarding //against// CodeGen. I think `GetValueAtEndOfBlock` can also generate SSA, the function for this is `FindValueForBlock`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140404/new/

https://reviews.llvm.org/D140404