[PATCH] D140404: Patch for dbg variable instrinsics to point towards cloned values in JumpThreading

Jeremy Morse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 7 03:30:44 PST 2023


jmorse added a comment.

/me squints -- I think the idea here was that if SSAUpdater has a value at the end of the block we can use that and it won't cause new codegen; but then we're using `GetValueInMiddleOfBlock`, which will generate code in certain circumstances.

@StephenTozer @BenJMudd Presumably we can just use GetValueAtEndOfBlock as this isn't a general SSA update query, we have a guarantee that only blocks outside of the the (threaded) value definitions will be updated, where there's no need to consider definitions in the middle of the block.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140404/new/

https://reviews.llvm.org/D140404



More information about the llvm-commits mailing list