[PATCH] D136233: [SimpleLoopUnswitch] Inject loop-invariant conditions and unswitch them when it's profitable

[Serguei Katkov via Phabricator via llvm-commits]

skatkov added inline comments.


================
Comment at: llvm/test/Transforms/SimpleLoopUnswitch/inject-invariant-conditions.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt < %s -S -passes="loop(simple-loop-unswitch<nontrivial>),simplifycfg" | FileCheck %s
+; RUN: opt < %s -S -passes="loop-mssa(simple-loop-unswitch<nontrivial>),simplifycfg" -verify-memoryssa | FileCheck %s
----------------
mkazantsev wrote:
> skatkov wrote:
> > can you please explicitly add -simple-loop-unswitch-inject-invariant-conditions=true here.
> > May be even makes sense to land it with off by default and switch it on as a separate commit.
> I don't see any value in merging something that doesn't work. It won't be tested.
I did not say "Don't switch it off" I said switch it on a separate commit to avoid possible big reverts.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136233/new/

https://reviews.llvm.org/D136233