[PATCH] D143409: [SCEV][IndVarSimplify] Support known dominating slt/ult elimination

Aleksandr Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 7 02:13:30 PST 2023


aleksandr.popov added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/SimplifyIndVar.cpp:756
+         (isa<ShlOperator>(BO) && strengthenRightShift(BO, IVOperand));
+}
+
----------------
mkazantsev wrote:
> How is that related to what the patch claims to do?  Should it be a separate patch with separate tests?
Now there are 2 places where we are doing BO strengthen: before and inside the loop, so I though it would be better to move this code to a separate method to reduce repeating


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143409/new/

https://reviews.llvm.org/D143409



More information about the llvm-commits mailing list