[PATCH] D143293: AMDGPU: Use module flag to get code object version at IR level folow-up

[Ivan Kosarev via Phabricator via llvm-commits]

kosarev added a comment.

Looks good to me, but I don't know enough about this code to approve.



================
Comment at: llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.h:123
   TargetIDSetting SramEccSetting;
+  unsigned CodeObjectVersion;
 
----------------
cfang wrote:
> kosarev wrote:
> > We probably want this initialised -- regardless of whether it is then assigned a value?
> Initialize it to 0, and I think this value will never been used.
Sorry, it seems I missed it that we also initialise it in the constructor. We probably don't need both the initialisers.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143293/new/

https://reviews.llvm.org/D143293