[PATCH] D143468: [CMake] Remove custom ccache CMake logic
Tobias Hieta via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 6 23:38:41 PST 2023
thieta created this revision.
thieta added reviewers: tstellar, beanz, ccotter, phosek.
Herald added subscribers: Moerafaat, zero9178, bzcheeseman, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst, shauheen, rriddle, mehdi_amini, thopre.
Herald added a project: All.
thieta requested review of this revision.
Herald added subscribers: stephenneuendorffer, nicolasvasilache.
Herald added projects: MLIR, LLVM.
CMake supports CMAKE_CXX_COMPILER_LAUNCHER since CMake 3.4
so this custom CMake logic we had in LLVM can now be removed.
The only downside with this is that we can't set ccache
options from LLVM CMake, but it's arguable that this doesn't
belong in LLVM but should be done in a script calling the
build.
This was discussed in the forums here:
https://discourse.llvm.org/t/tips-for-incremental-building/67289/4?u=tobiashieta
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D143468
Files:
llvm/CMakeLists.txt
llvm/docs/CMake.rst
llvm/docs/ReleaseNotes.rst
mlir/utils/clang-tidy/README.md
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D143468.495394.patch
Type: text/x-patch
Size: 4403 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230207/c96d8c05/attachment.bin>
More information about the llvm-commits
mailing list