[PATCH] D138899: [DAGCombiner] handle more store value forwarding

ChenZheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 6 21:36:02 PST 2023


shchenz added a comment.

In D138899#4108103 <https://reviews.llvm.org/D138899#4108103>, @nemanjai wrote:

> @shchenz You neither incorporated nor responded to the comments I left when approving the patch. Could you please respond to the two comments as to why you felt they did not need to be incorporated into the final patch?

I am really sorry, Nemanja. @nemanjai I remember I addressed your comments and tested the new update when I committed this patch. I must forget to amend the changes to the final commit. 63854f91d3ee1056796a5ef27753648396cac6ec <https://reviews.llvm.org/rG63854f91d3ee1056796a5ef27753648396cac6ec> is committed for the two comments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138899/new/

https://reviews.llvm.org/D138899



More information about the llvm-commits mailing list