[PATCH] D140460: [RISCV][MC] Add support for experimental zfa extension

Mon Feb 6 18:08:40 PST 2023

joshua-arch1 added a comment.

Ping.

================
Comment at: llvm/lib/Target/RISCV/MCTargetDesc/RISCVInstPrinter.cpp:166
+  else
+    O << bit_cast<float>(RISCVLoadFPImm::getFPImm(MO.getImm()));
+}
----------------
craig.topper wrote:
> joshua-arch1 wrote:
> > craig.topper wrote:
> > > I think we should use APFloat::toString here to print with full precision.
> > What formatprecision should I choose for the second parameter in toString()?
> I think the default value will print whatever precision is needed.
Since we only need to print 'min' in the dissassembler, I don't think it neccessary to print with full precision.  This issue doesn't exist for other values.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140460/new/

https://reviews.llvm.org/D140460