[PATCH] D143445: [RISCV] Refactor RISCVDisassembler::getInstruction to remove repeated code. NFC

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 6 17:23:30 PST 2023


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/Disassembler/RISCVDisassembler.cpp:450
     Insn = support::endian::read32le(Bytes.data());
+
     if (STI.getFeatureBits()[RISCV::FeatureStdExtZdinx] &&
----------------
reames wrote:
> whitespace change
It was intentional. The 2 byte code had a blank line after Insn. I was making them consistent.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143445/new/

https://reviews.llvm.org/D143445



More information about the llvm-commits mailing list