[PATCH] D135128: [clang][cli] Simplify repetitive macro invocations

Mon Feb 6 17:11:07 PST 2023

stella.stamenova added a comment.

In D135128#4107816 <https://reviews.llvm.org/D135128#4107816>, @jansvoboda11 wrote:

> @stella.stamenova ping

Thanks for the reminder!

I spent some time looking for a combination of VS + Win 10 SDK that would work with the new flag, and I believe I've found (at least one). It looks like versions of the Win 10 SDK prior to 20348 do not work, but 20348 works fine in local testing with the latest versions of VS 2019 -- some newer versions of VS have a crash in some of the mlir tests, so I needed to find the right version there too.

Long story short, I believe VS 2019 16.11.23 with Win 10 SDK 10.0.20348.0 should work fine based on some local tests. I've updated the bot to these versions and I'd like to give it a day or so to make sure something else didn't break. After that, the new flag should work.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135128/new/

https://reviews.llvm.org/D135128