[PATCH] D143295: [bazel] Move bazel configuration to a Python script

[Aaron Siddhartha Mondal via Phabricator via llvm-commits]

aaronmondal added inline comments.


================
Comment at: utils/bazel/configure_overlay.py:68
+        cmd_str = " ".join([str(arg) for arg in cmd])
+        print(f"Failed to execute overlay script: '{cmd}'\n" +
+              f"Exited with code {e.returncode}\n" +
----------------



================
Comment at: utils/bazel/configure_overlay.py:114
+            # Then `v` will not be desired form, like "${...} CACHE"
+            if c[k] != None:
+                continue
----------------



================
Comment at: utils/bazel/configure_overlay.py:156-158
+        filepath = os.path.join(args.dst, "vars.bzl"),
+        header = "# Generated from {}\n\n".format(llvm_cmake),
+        vars = vars,
----------------



================
Comment at: utils/bazel/configure_overlay.py:168-169
+if __name__ == "__main__":
+  _check_python_version()
+  main(parse_arguments())
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143295/new/

https://reviews.llvm.org/D143295