[PATCH] D143029: [RISCV] Add vendor-defined XTHeadBa (address-generation) extension

[Craig Topper via Phabricator via llvm-commits]

craig.topper added a comment.

LGTM



================
Comment at: llvm/test/MC/RISCV/rv32xtheadba-valid.s:1
+# With Bitmanip base extension:
+# RUN: llvm-mc %s -triple=riscv32 -mattr=+xtheadba -show-encoding \
----------------
I think this "Bitmanip base" was copied from Zbb? Should we adjust it to include T-Head?


================
Comment at: llvm/test/MC/RISCV/rv64xtheadba-invalid.s:1
+# RUN: not llvm-mc -triple riscv64 -mattr=+xtheadba < %s 2>&1 | FileCheck %s
+
----------------
Can we merge this test with rv32xtheadba-invalid.s?


================
Comment at: llvm/test/MC/RISCV/rv64xtheadba-valid.s:1
+# With Bitmanip base extension:
+# RUN: llvm-mc %s -triple=riscv64 -mattr=+xtheadba -show-encoding \
----------------
Can we merge this with rv32xtheadba-valid.s?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143029/new/

https://reviews.llvm.org/D143029