[PATCH] D143320: [bazel] Rework zlib dependency

Mon Feb 6 14:38:04 PST 2023

MaskRay added a comment.

In D143320#4106744 <https://reviews.llvm.org/D143320#4106744>, @aaronmondal wrote:

> @MaskRay While we're at it, what do you think about changing zlib to zlib-ng? (https://github.com/zlib-ng/zlib-ng) The original zlib still didn't address https://github.com/madler/zlib/issues/633 and I'd rather spend time on writng a buildfile for zlib-ng than to set `-Wno-strict-prototypes` (or get spammed by a million warnings).
>
> Since this only changes the dep in the Bazel build that should be fine right? Do any other Bazel users have an opinion on this? Note that this wouldn't require codechanges in LLVM. We'd just switch to a different zlib-API-compatible implementation for the Bazel build.

Using zlib-ng seems reasonable. I made another comment on https://github.com/madler/zlib/issues/633 just to wish that madler can change his mind...

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143320/new/

https://reviews.llvm.org/D143320