[PATCH] D143351: [bazel] Remove unused dependency on libxml2

[Aaron Siddhartha Mondal via Phabricator via llvm-commits]

aaronmondal added a comment.

In D143351#4107657 <https://reviews.llvm.org/D143351#4107657>, @GMNGeoffrey wrote:

> Hmm I'm trying to remember this history on this one too. I think this was added after hitting a real bug on Windows... Again @chandlerc

This shouldn't affect anyone using default Bazel configs. The functionality that depends on libxml is disabled (as in, disabled on the preprocessor level). Not having xml2 support disables symbols in `llvm/lib/WindowsManifest/WindowsManifestMerger.cpp`, but linking xml2 it here without setting `LLVM_ENABLE_XML2` has no effect.

This functionality should currently only be usable if you manually patched the Bazel configs.

Ultimately I'd like to make this a configurable flag depending on/setting `LLVM_ENABLE_XML2`, but I think the CMake-to-Bazel scripts are't ready to support this yet. It's probably better to wait for (can't find diff, will edit in later) to get through first and then add configurability separately.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143351/new/

https://reviews.llvm.org/D143351