[PATCH] D139752: cmake: Enable 64bit off_t on 32bit glibc systems

Alex Reinking via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 6 11:24:34 PST 2023


alexreinking added a comment.

In D139752#4107698 <https://reviews.llvm.org/D139752#4107698>, @srj wrote:

> I'm tempted to suggest that LLVM considers converting it to a 'traditional' CMake list, but that might cause even more dislocation/problems from code that assumes otherwise...

This would definitely be the Right Thing to do, given that every other CMake package I've seen (including all the first-party find modules) use semicolon separators in their `${PACKAGE_NAME}_DEFINITIONS` variables. Whether or not it's practical is a separate question.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139752/new/

https://reviews.llvm.org/D139752



More information about the llvm-commits mailing list