[PATCH] D139752: cmake: Enable 64bit off_t on 32bit glibc systems

[Steven Johnson via Phabricator via llvm-commits]

srj added a comment.

In D139752#4107678 <https://reviews.llvm.org/D139752#4107678>, @alexreinking wrote:

> This patch might cause problems for other downstreams that (reasonably, but incorrectly) assume that `LLVM_DEFINITIONS` is a typical CMake list rather than a space-separated list.

In general, trying to have CMake lists separated by spaces (or really, anything other than a semicolon) is a recipe for flakiness and pain; this is regrettable, but a fact of life with CMake, unfortunately. I'm tempted to suggest that LLVM considers converting it to a 'traditional' CMake list, but that might cause even more dislocation/problems from code that assumes otherwise...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139752/new/

https://reviews.llvm.org/D139752