[PATCH] D143323: [ConstraintElim] Add reproducer remarks.
Thorsten via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 6 11:00:38 PST 2023
tschuett added inline comments.
================
Comment at: llvm/lib/Transforms/Scalar/ConstraintElimination.cpp:778
-static bool checkAndReplaceCondition(CmpInst *Cmp, ConstraintInfo &Info) {
+struct ReproducerEntry {
+ CmpInst *Cond;
----------------
paquette wrote:
> doxygen comments for this?
You can, may, or should wrap the struct with an anonymous namespace. You are very careful with static.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143323/new/
https://reviews.llvm.org/D143323
More information about the llvm-commits
mailing list