[PATCH] D143388: [Lint] Use new PM instead of legacy PM in lintFunction and lintModule

Mon Feb 6 10:41:59 PST 2023

bjope added a comment.

Had to revert this due to lots of buildbots failing when linking bugpoint.
Typically like this:

  48.373 [370/4/3450] Linking CXX executable bin/bugpoint
  FAILED: bin/bugpoint 
  : && /usr/bin/c++ -fPIC -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-maybe-uninitialized -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -Wl,--export-dynamic  -Wl,-rpath-link,/home/uweigand/sandbox/buildbot/mlir-s390x-linux/build/./lib tools/bugpoint/CMakeFiles/bugpoint.dir/BugDriver.cpp.o tools/bugpoint/CMakeFiles/bugpoint.dir/CrashDebugger.cpp.o tools/bugpoint/CMakeFiles/bugpoint.dir/ExecutionDriver.cpp.o tools/bugpoint/CMakeFiles/bugpoint.dir/ExtractFunction.cpp.o tools/bugpoint/CMakeFiles/bugpoint.dir/FindBugs.cpp.o tools/bugpoint/CMakeFiles/bugpoint.dir/Miscompilation.cpp.o tools/bugpoint/CMakeFiles/bugpoint.dir/OptimizerDriver.cpp.o tools/bugpoint/CMakeFiles/bugpoint.dir/ToolRunner.cpp.o tools/bugpoint/CMakeFiles/bugpoint.dir/bugpoint.cpp.o -o bin/bugpoint  -Wl,-rpath,"\$ORIGIN/../lib"  lib/libLLVMSystemZAsmParser.a  lib/libLLVMSystemZCodeGen.a  lib/libLLVMSystemZDesc.a  lib/libLLVMSystemZInfo.a  lib/libLLVMAnalysis.a  lib/libLLVMBitWriter.a  lib/libLLVMCodeGen.a  lib/libLLVMExtensions.a  lib/libLLVMCore.a  lib/libLLVMipo.a  lib/libLLVMIRReader.a  lib/libLLVMAggressiveInstCombine.a  lib/libLLVMInstCombine.a  lib/libLLVMInstrumentation.a  lib/libLLVMLinker.a  lib/libLLVMObjCARCOpts.a  lib/libLLVMScalarOpts.a  lib/libLLVMSupport.a  lib/libLLVMTarget.a  lib/libLLVMTargetParser.a  lib/libLLVMTransformUtils.a  lib/libLLVMVectorize.a  -lpthread  lib/libLLVMAsmPrinter.a  lib/libLLVMSelectionDAG.a  lib/libLLVMCodeGen.a  lib/libLLVMObjCARCOpts.a  lib/libLLVMTarget.a  lib/libLLVMBitWriter.a  lib/libLLVMFrontendOpenMP.a  lib/libLLVMScalarOpts.a  lib/libLLVMAggressiveInstCombine.a  lib/libLLVMInstCombine.a  lib/libLLVMTransformUtils.a  lib/libLLVMAnalysis.a  lib/libLLVMProfileData.a  lib/libLLVMSymbolize.a  lib/libLLVMDebugInfoDWARF.a  lib/libLLVMDebugInfoPDB.a  lib/libLLVMObject.a  lib/libLLVMIRReader.a  lib/libLLVMAsmParser.a  lib/libLLVMMCParser.a  lib/libLLVMBitReader.a  lib/libLLVMTextAPI.a  lib/libLLVMDebugInfoMSF.a  lib/libLLVMCore.a  lib/libLLVMRemarks.a  lib/libLLVMBitstreamReader.a  lib/libLLVMMC.a  lib/libLLVMBinaryFormat.a  lib/libLLVMTargetParser.a  lib/libLLVMDebugInfoCodeView.a  lib/libLLVMSupport.a  lib/libLLVMDemangle.a  -lrt  -ldl  -lpthread  -lm  /usr/lib/s390x-linux-gnu/libz.so && :
  /usr/bin/ld: lib/libLLVMAnalysis.a(Lint.cpp.o): in function `llvm::lintFunction(llvm::Function const&)':
  Lint.cpp:(.text._ZN4llvm12lintFunctionERKNS_8FunctionE+0x62): undefined reference to `llvm::PipelineTuningOptions::PipelineTuningOptions()'
  /usr/bin/ld: Lint.cpp:(.text._ZN4llvm12lintFunctionERKNS_8FunctionE+0x90): undefined reference to `llvm::PassBuilder::PassBuilder(llvm::TargetMachine*, llvm::PipelineTuningOptions, std::optional<llvm::PGOOptions>, llvm::PassInstrumentationCallbacks*)'
  /usr/bin/ld: Lint.cpp:(.text._ZN4llvm12lintFunctionERKNS_8FunctionE+0xde): undefined reference to `llvm::PassBuilder::registerModuleAnalyses(llvm::AnalysisManager<llvm::Module>&)'
  /usr/bin/ld: Lint.cpp:(.text._ZN4llvm12lintFunctionERKNS_8FunctionE+0xec): undefined reference to `llvm::PassBuilder::registerFunctionAnalyses(llvm::AnalysisManager<llvm::Function>&)'
  /usr/bin/ld: Lint.cpp:(.text._ZN4llvm12lintFunctionERKNS_8FunctionE+0x102): undefined reference to `llvm::PassBuilder::crossRegisterProxies(llvm::AnalysisManager<llvm::Loop, llvm::LoopStandardAnalysisResults&>&, llvm::AnalysisManager<llvm::Function>&, llvm::AnalysisManager<llvm::LazyCallGraph::SCC, llvm::LazyCallGraph&>&, llvm::AnalysisManager<llvm::Module>&)'
  /usr/bin/ld: lib/libLLVMAnalysis.a(Lint.cpp.o): in function `llvm::lintModule(llvm::Module const&)':
  Lint.cpp:(.text._ZN4llvm10lintModuleERKNS_6ModuleE+0x46): undefined reference to `llvm::PipelineTuningOptions::PipelineTuningOptions()'
  /usr/bin/ld: Lint.cpp:(.text._ZN4llvm10lintModuleERKNS_6ModuleE+0x70): undefined reference to `llvm::PassBuilder::PassBuilder(llvm::TargetMachine*, llvm::PipelineTuningOptions, std::optional<llvm::PGOOptions>, llvm::PassInstrumentationCallbacks*)'
  /usr/bin/ld: Lint.cpp:(.text._ZN4llvm10lintModuleERKNS_6ModuleE+0xc2): undefined reference to `llvm::PassBuilder::registerModuleAnalyses(llvm::AnalysisManager<llvm::Module>&)'
  /usr/bin/ld: Lint.cpp:(.text._ZN4llvm10lintModuleERKNS_6ModuleE+0xd0): undefined reference to `llvm::PassBuilder::registerFunctionAnalyses(llvm::AnalysisManager<llvm::Function>&)'
  /usr/bin/ld: Lint.cpp:(.text._ZN4llvm10lintModuleERKNS_6ModuleE+0xe6): undefined reference to `llvm::PassBuilder::crossRegisterProxies(llvm::AnalysisManager<llvm::Loop, llvm::LoopStandardAnalysisResults&>&, llvm::AnalysisManager<llvm::Function>&, llvm::AnalysisManager<llvm::LazyCallGraph::SCC, llvm::LazyCallGraph&>&, llvm::AnalysisManager<llvm::Module>&)'
  collect2: error: ld returned 1 exit status

Would perhaps be simpler to just remove lintFunction and lintModule. Not sure if anyone really need those debug support helpers.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143388/new/

https://reviews.llvm.org/D143388