[PATCH] D139130: InstCombine: Fold and (fcmp), (is.fpclass) into is.fpclass

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp:1308
+        if (IsFabs)
+          Mask = ~fcNan; // FIXME: Can't write a test
+      } else {
----------------
foad wrote:
> Should be `Mask = 0`.
> 
> Can you imagine any way of fixing the FIXME? If not I wouldn't bother marking it as FIXME.
This was mostly for me when I was trying to make sure all the paths were tested. I think it's even harder now that I did the fneg/fabs fold into the test mask combine


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp:1282
+      //
+      //   fcmp oeq x, +inf -> is_fpclass x, fcPosInf
+      //   fcmp oeq fabs(x), +inf -> is_fpclass x, fcInf
----------------
sepavloff wrote:
> `oeq` seems irrelevant in this block.
it's relevant but now moved to the other patch for zero handling 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139130/new/

https://reviews.llvm.org/D139130