[PATCH] D143296: [MSan] Fix calling pointers to varargs functions on SystemZ

Ulrich Weigand via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 6 09:24:44 PST 2023


uweigand accepted this revision.
uweigand added a comment.
This revision is now accepted and ready to land.

> Fix by checking this attribute on the current function. Alternatively, one could try the callee first, but this is pointless, since one should not be mixing hardfloat and softfloat code anyway.

Agreed.  If the current function is compiled for soft-float, it cannot use any FP registers and therefore could not set up arguments for a hard-float routine.

The patch LGTM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143296/new/

https://reviews.llvm.org/D143296



More information about the llvm-commits mailing list