[PATCH] D143321: [DRAFT] [IR] Add instruction IDs to simplify debugging.

[Yury Gribov via Phabricator via llvm-commits]

ygribov added a comment.

In D143321#4106526 <https://reviews.llvm.org/D143321#4106526>, @nhaehnle wrote:

> These data structures have been designed quite carefully with size in mind, so I am against making these debug-only additions.

Right. I wonder if separate Cmake switch could alleviate this.

> The change as-is is also not thread-safe.

That's true. What's worse, I'm afraid it will be inherently racy in parallel compilations.

> Have you tried just attaching metadata to instructions instead?

I haven't, thanks for the suggestion.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143321/new/

https://reviews.llvm.org/D143321