[PATCH] D142803: [ComplexLogicCombine 1/?] Implement a general way to simplify complex logical operations.

Mon Feb 6 06:48:31 PST 2023

spatel added a comment.

In D142803#4105675 <https://reviews.llvm.org/D142803#4105675>, @bcl5980 wrote:

> Ping.
> Anyone can help to review it? Or is this necessary for llvm? 
> I try to run it on test-suite, it looks only spec2017 502.gcc can trigger this 6 times.

It seems like a nice improvement. It would be great if it eventually allows removing some of the pattern-specific complex logic reductions that we have in InstCombine/InstSimplify:
https://github.com/llvm/llvm-project/blob/b5ee4f755fcff56243f6ff0cea9e7a722259304a/llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp#L1719

I had not seen "boolean ring" before this. Do you know if that is implemented in any other programs/compilers?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142803/new/

https://reviews.llvm.org/D142803