[PATCH] D142989: [extract_symbols.py] Better handling of templates

Mon Feb 6 06:42:37 PST 2023

simon_tatham accepted this revision.
simon_tatham added a comment.
This revision is now accepted and ready to land.

LGTM, with a small commenting nit.

================
Comment at: llvm/utils/extract_symbols.py:523-525
+    #  * If they're a template instantiation then that template is referenced
+    #    somewhere. This is because we need to export any explicitly
+    #    instantiated templates, and we expect those to be referenced in some
----------------
Grammar/clarity nit: this comment is now incoherent. Previously its overall structure was a single sentence saying "Print symbols which both [do this] and [are not that]", which made it clear how the two individual conditions combined into the overall decision. But now the "[are not that]" bullet point is replaced with a sentence rather than a predicate.

Suggest rewording to clarify how the revised two conditions are combined.

Reading the code, I _think_ it's "Print symbols which both: [appear in exactly one input] and [are not an unreferenced template]".

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142989/new/

https://reviews.llvm.org/D142989